Re: [voidlinux/void-packages] an: rebuild missing package in repos (#12879)

Michael Gehring at Fri, 30 Mar 2018 17:44:18 +0000 (UTC)
ebfe requested changes on this pull request. > @@ -3,7 +3,7 @@ pkgname=an version=1.2 revision=1 build_style=gnu-makefile -make_install_args='INSTALLDIR=$(DESTDIR)/usr/bin' +make_install_args="INSTALLDIR=$(DESTDIR)/usr/bin" This doesn't work and messes with the masterdir. Also see package content.
cr6git at Sat, 31 Mar 2018 10:09:22 +0000 (UTC)
cr6git commented on this pull request. > @@ -3,7 +3,7 @@ pkgname=an version=1.2 revision=1 build_style=gnu-makefile -make_install_args='INSTALLDIR=$(DESTDIR)/usr/bin' +make_install_args="INSTALLDIR=$(DESTDIR)/usr/bin" @ebfe I'm sure your comment makes sense, but I don't get it. I don't see what is wrong here?
John Zimmermann at Sat, 31 Mar 2018 03:13:11 -0700
Johnnynator commented on this pull request. > @@ -3,7 +3,7 @@ pkgname=an version=1.2 revision=1 build_style=gnu-makefile -make_install_args='INSTALLDIR=$(DESTDIR)/usr/bin' +make_install_args="INSTALLDIR=$(DESTDIR)/usr/bin" Hes probably saying that (DESTDIR) should be ${DESTDIR}.
cr6git at Sat, 31 Mar 2018 10:34:38 +0000 (UTC)
cr6git commented on this pull request. > @@ -3,7 +3,7 @@ pkgname=an version=1.2 revision=1 build_style=gnu-makefile -make_install_args='INSTALLDIR=$(DESTDIR)/usr/bin' +make_install_args="INSTALLDIR=$(DESTDIR)/usr/bin" @Johnnynator oh!! :hushed: good catch! I just noticed it.
cr6git at Sat, 31 Mar 2018 10:41:36 +0000 (UTC)
cr6git commented on this pull request. > @@ -3,7 +3,7 @@ pkgname=an version=1.2 revision=1 build_style=gnu-makefile -make_install_args='INSTALLDIR=$(DESTDIR)/usr/bin' +make_install_args="INSTALLDIR=$(DESTDIR)/usr/bin" @Johnnynator it's even worse: now the binary is missing in the resulting package??
John Zimmermann at Sat, 31 Mar 2018 03:51:59 -0700
Johnnynator commented on this pull request. > @@ -3,7 +3,7 @@ pkgname=an version=1.2 revision=1 build_style=gnu-makefile -make_install_args='INSTALLDIR=$(DESTDIR)/usr/bin' +make_install_args="INSTALLDIR=$(DESTDIR)/usr/bin" Actually $() is the way GNU Make handles variables. So it was correct. You have to use `'` instead `"` so the $() doesn't get executed.
John Zimmermann at Sat, 31 Mar 2018 10:53:00 +0000 (UTC)
Johnnynator commented on this pull request. > @@ -3,7 +3,7 @@ pkgname=an version=1.2 revision=1 build_style=gnu-makefile -make_install_args='INSTALLDIR=$(DESTDIR)/usr/bin' +make_install_args="INSTALLDIR=$(DESTDIR)/usr/bin" As you can see in the travis log ``` => an-1.2_1: running post-install hook: 98-lib32 ... /void-packages/srcpkgs/an/template: line 6: DESTDIR: command not found ```
Michael Gehring at Sat, 31 Mar 2018 10:53:37 +0000 (UTC)
ebfe commented on this pull request. > @@ -3,7 +3,7 @@ pkgname=an version=1.2 revision=1 build_style=gnu-makefile -make_install_args='INSTALLDIR=$(DESTDIR)/usr/bin' +make_install_args="INSTALLDIR=$(DESTDIR)/usr/bin" http://wiki.bash-hackers.org/syntax/quoting `'` vs '`"`
cr6git at Sat, 31 Mar 2018 04:03:16 -0700
cr6git commented on this pull request. > @@ -3,7 +3,7 @@ pkgname=an version=1.2 revision=1 build_style=gnu-makefile -make_install_args='INSTALLDIR=$(DESTDIR)/usr/bin' +make_install_args="INSTALLDIR=$(DESTDIR)/usr/bin" I've found another solution: `sed` this wrong Makefile. Also, hostmakedepends="icu-devel" wasn't needed, I will remove it. I think it's necessary to bumb the revision then...
Leаh Neukirchen at Sun, 01 Apr 2018 04:01:17 -0700
Merged #12879.