Affects also few other packages, e.g. luafilesystem
You can view, comment on, or merge this pull request online at:
https://github.com/voidlinux/void-packages/pull/13443
-- Commit Summary --
* xbps-src: update-check: handle underscores in upstream version string
-- File Changes --
M common/xbps-src/shutils/update_check.sh (1)
M srcpkgs/iverilog/update (1)
M srcpkgs/lowdown/update (3)
M srcpkgs/portaudio/update (1)
-- Patch Links --
https://github.com/voidlinux/void-packages/pull/13443.patch
https://github.com/voidlinux/void-packages/pull/13443.diff
maxice8 commented on this pull request.
> @@ -1,4 +1 @@
-# This pattern is incomplete, it finds out the versions like '0_3_1' but
-# comparison with 'xbps-uhelper cmpver' results in it being always treated
-# as a lower version
pattern="VERSION_\K[\d_]+"
i think it should be `\d\.` instead of `\d_`
maxice8 commented on this pull request.
> @@ -1,4 +1 @@
-# This pattern is incomplete, it finds out the versions like '0_3_1' but
-# comparison with 'xbps-uhelper cmpver' results in it being always treated
-# as a lower version
pattern="VERSION_\K[\d_]+"
note: i didn't test.
Chocimier commented on this pull request.
> @@ -1,4 +1 @@
-# This pattern is incomplete, it finds out the versions like '0_3_1' but
-# comparison with 'xbps-uhelper cmpver' results in it being always treated
-# as a lower version
pattern="VERSION_\K[\d_]+"
That is the point of using `update` file: author uses underscores in tags. https://github.com/kristapsdz/lowdown/releases