freshprince commented on this pull request.
> @@ -12,7 +12,8 @@ checksum=8179a7a843d257ddb585f4c65599844bc0e516fe85e97f6f87a7ceade4eb5165
hostmakedepends="pkg-config"
makedepends="ncurses-devel faad2-devel libflac-devel libao-devel libmad-devel
libmodplug-devel libmp4v2-devel libmpcdec-devel pulseaudio-devel
- opusfile-devel wavpack-devel alsa-lib-devel libvorbis-devel ffmpeg-devel"
Thanks for your feedback but I think I don't understand. `revision` is in line 4 and `depends` are in line 12 and 13 and clearly below it?
I mean put the directly below
On Wed, May 2, 2018, 10:14 David Flatz <notifications@github.com> wrote:
> *@freshprince* commented on this pull request.
> ------------------------------
>
> In srcpkgs/cmus/template
> <https://github.com/voidlinux/void-packages/pull/14046#discussion_r1854=
90835>
> :
>
> > @@ -12,7 +12,8 @@ checksum=3D8179a7a843d257ddb585f4c65599844bc0e516fe=
85e97f6f87a7ceade4eb5165
> hostmakedepends=3D"pkg-config"
> makedepends=3D"ncurses-devel faad2-devel libflac-devel libao-devel lib=
mad-devel
> libmodplug-devel libmp4v2-devel libmpcdec-devel pulseaudio-devel
> - opusfile-devel wavpack-devel alsa-lib-devel libvorbis-devel ffmpeg-de=
vel"
>
> Thanks for your feedback but I think I don't understand. revision is in=
> line 4 and depends are in line 12 and 13 and clearly below it?
>
> =E2=80=94
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/voidlinux/void-packages/pull/14046#discussion_r1854=
90835>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AdUHTXat_l6MeJHGKkY6=
tAD2IfOgsWajks5tubFHgaJpZM4Tvat7>
> .
>
-- =
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/14046#issuecomment-385982=
449=
freshprince commented on this pull request.
> @@ -1,7 +1,7 @@
# Template file for 'cmus'
pkgname=cmus
version=2.7.1
-revision=3
+revision=4
short_desc="Small, fast and powerful console music player"
maintainer="Juan RP <xtraeme@voidlinux.eu>"
license="GPL-2"
I changed it, but I'm a bit confused now. The [manual](https://github.com/voidlinux/void-packages/blob/master/Manual.md) states that `license` should be
> A string matching any license file available in `/usr/share/licenses`.
And there is no `GPL-2.0` in `/usr/share/licenses` but there is `GPL-2`.
maxice8 commented on this pull request.
> @@ -1,7 +1,7 @@
# Template file for 'cmus'
pkgname=cmus
version=2.7.1
-revision=3
+revision=4
short_desc="Small, fast and powerful console music player"
maintainer="Juan RP <xtraeme@voidlinux.eu>"
license="GPL-2"
yeah sorry we are in transition to adopt SPDX identifiers for licenses, see https://github.com/voidlinux/void-packages/issues/12219
the manual.md is outdated in that regard
maxice8 commented on this pull request.
> short_desc="Small, fast and powerful console music player"
maintainer="Juan RP <xtraeme@voidlinux.eu>"
-license="GPL-2"
+license="GPL-2.0"
the SPDX identifier for GPL licenses need -or-later or -only.