> @@ -0,0 +1,13 @@
> +# Template file for 'compute'
> +pkgname=3D"compute"
> +version=3D"1.0.4"
> +revision=3D1
> +build_style=3Dgnu-configure
> +short_desc=3D"A command-line program that performs simple calculations=
on input files"
> +maintainer=3D"oliver <ohemming@gmail.com>"
> +license=3D"GPL-3"
> +homepage=3D"http://compute.teamerlich.org/"
> +makedepends=3D"gperf perl"
> +only_for_archs=3D"i686 x86_64 x86_64-musl"
Point taken on the makedepends versus hostmakedepends... makes sense.
The reason the only_for_archs was that Travis gave an error on the armv*
parts and I don't have a way, that I know of, to test it.
On Thu, Apr 14, 2016 at 4:44 PM, Toyam Cox <notifications@github.com> wro=
te:
> In srcpkgs/compute/template
> <https://github.com/voidlinux/void-packages/pull/4029#discussion_r59788=
351>
> :
>
> > @@ -0,0 +1,13 @@
> > +# Template file for 'compute'
> > +pkgname=3D"compute"
> > +version=3D"1.0.4"
> > +revision=3D1
> > +build_style=3Dgnu-configure
> > +short_desc=3D"A command-line program that performs simple calculatio=
ns on input files"
> > +maintainer=3D"oliver <ohemming@gmail.com>"
> > +license=3D"GPL-3"
> > +homepage=3D"http://compute.teamerlich.org/"
> > +makedepends=3D"gperf perl"
> > +only_for_archs=3D"i686 x86_64 x86_64-musl"
>
> For what reason?
>
> =E2=80=94
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
> <https://github.com/voidlinux/void-packages/pull/4029/files/2c4cda23730=
c64708e03c540ac55c3e20d065bd9#r59788351>
>
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029/files/2c4cda23730c64=
708e03c540ac55c3e20d065bd9#r59802566=
> @@ -0,0 +1,13 @@
> +# Template file for 'compute'
> +pkgname=3D"compute"
> +version=3D"1.0.4"
> +revision=3D1
> +build_style=3Dgnu-configure
> +short_desc=3D"A command-line program that performs simple calculations=
on input files"
> +maintainer=3D"oliver <ohemming@gmail.com>"
> +license=3D"GPL-3"
> +homepage=3D"http://compute.teamerlich.org/"
> +makedepends=3D"gperf perl"
> +only_for_archs=3D"i686 x86_64 x86_64-musl"
I looked at the failed builds (didn't realise it was clickable) and I see=
the armv ones failed with:
/usr/bin/perl: bad interpreter: No such file or directory
(https://travis-ci.org/voidlinux/void-packages/jobs/122935455)
Would this be resolved by swapping the makedepends line for
hostmakedepends? I do see perl is built for armv.
-makedepends=3D"gperf perl"
+hostmakedepends=3D"gperf perl"
Do repeated builds on Travis cause you guys tons of unnecessary email? I=
don't mind trial/error to get this right but not if you're getting notifi=
ed
all the time.
On Thu, Apr 14, 2016 at 5:22 PM, Duncan Overbruck <notifications@github.c=
om>
wrote:
> In srcpkgs/compute/template
> <https://github.com/voidlinux/void-packages/pull/4029#discussion_r59794=
294>
> :
>
> > @@ -0,0 +1,13 @@
> > +# Template file for 'compute'
> > +pkgname=3D"compute"
> > +version=3D"1.0.4"
> > +revision=3D1
> > +build_style=3Dgnu-configure
> > +short_desc=3D"A command-line program that performs simple calculatio=
ns on input files"
> > +maintainer=3D"oliver <ohemming@gmail.com>"
> > +license=3D"GPL-3"
> > +homepage=3D"http://compute.teamerlich.org/"
> > +makedepends=3D"gperf perl"
> > +only_for_archs=3D"i686 x86_64 x86_64-musl"
>
> Use nocross=3Dyes instead.
>
> =E2=80=94
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
> <https://github.com/voidlinux/void-packages/pull/4029/files/2c4cda23730=
c64708e03c540ac55c3e20d065bd9#r59794294>
>
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029/files/2c4cda23730c64=
708e03c540ac55c3e20d065bd9#r59804374=
> @@ -0,0 +1,13 @@
> +# Template file for 'compute'
> +pkgname="compute"
> +version="1.0.4"
> +revision=1
> +build_style=gnu-configure
> +short_desc="A command-line program that performs simple calculations on input files"
> +maintainer="oliver <ohemming@gmail.com>"
> +license="GPL-3"
> +homepage="http://compute.teamerlich.org/"
> +makedepends="gperf perl"
> +only_for_archs="i686 x86_64 x86_64-musl"
Probably. Remove the line entirely for now and just use the hostmakedepends as possible.
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029/files/2c4cda23730c64708e03c540ac55c3e20d065bd9#r59814362
> @@ -0,0 +1,19 @@
> +# Template file for 'compute'
> +pkgname="compute"
> +version="1.0.4"
> +revision=4
> +build_style=gnu-configure
> +short_desc="A command-line program that performs simple calculations on input files"
> +maintainer="oliver <ohemming@gmail.com>"
> +license="GPL-3"
> +homepage="http://compute.teamerlich.org/"
> +hostmakedepends="gperf perl"
> +distfiles="https://github.com/agordon/compute/releases/download/v${version}/${pkgname}-${version}.tar.gz"
> +checksum="cd0d09b2d7526fef34eb3f09e5b9d36e1346b093028fe981ef400ac065c7abbb"
> +
> +pre_configure() {
> +if [ "$CROSS_BUILD" ]; then
Please indent the contents of the function by an additional level.
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029/files/1c6e4177a21c2842e7a0f093d5f64285122c9e4a#r59814413
> +pkgname="compute"
> +version="1.0.4"
> +revision=4
> +build_style=gnu-configure
> +short_desc="A command-line program that performs simple calculations on input files"
> +maintainer="oliver <ohemming@gmail.com>"
> +license="GPL-3"
> +homepage="http://compute.teamerlich.org/"
> +hostmakedepends="gperf perl"
> +distfiles="https://github.com/agordon/compute/releases/download/v${version}/${pkgname}-${version}.tar.gz"
> +checksum="cd0d09b2d7526fef34eb3f09e5b9d36e1346b093028fe981ef400ac065c7abbb"
> +
> +pre_configure() {
> +if [ "$CROSS_BUILD" ]; then
> + # disable generating a man page with help2man while cross compiling.
> + sed -i '/^man_MANS = compute.1$/d' Makefile.in
Reasoning? help2man is available on cross...
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029/files/1c6e4177a21c2842e7a0f093d5f64285122c9e4a#r59814498
> +pkgname="compute"
> +version="1.0.4"
> +revision=4
> +build_style=gnu-configure
> +short_desc="A command-line program that performs simple calculations on input files"
> +maintainer="oliver <ohemming@gmail.com>"
> +license="GPL-3"
> +homepage="http://compute.teamerlich.org/"
> +hostmakedepends="gperf perl"
> +distfiles="https://github.com/agordon/compute/releases/download/v${version}/${pkgname}-${version}.tar.gz"
> +checksum="cd0d09b2d7526fef34eb3f09e5b9d36e1346b093028fe981ef400ac065c7abbb"
> +
> +pre_configure() {
> +if [ "$CROSS_BUILD" ]; then
> + # disable generating a man page with help2man while cross compiling.
> + sed -i '/^man_MANS = compute.1$/d' Makefile.in
Probably it comes with help2man bundled instead of using the system wide version. Can you try to change the lines to use a system-wide help2man instead?
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029/files/1c6e4177a21c2842e7a0f093d5f64285122c9e4a#r59815107
> +pkgname="compute"
> +version="1.0.4"
> +revision=4
> +build_style=gnu-configure
> +short_desc="A command-line program that performs simple calculations on input files"
> +maintainer="oliver <ohemming@gmail.com>"
> +license="GPL-3"
> +homepage="http://compute.teamerlich.org/"
> +hostmakedepends="gperf perl"
> +distfiles="https://github.com/agordon/compute/releases/download/v${version}/${pkgname}-${version}.tar.gz"
> +checksum="cd0d09b2d7526fef34eb3f09e5b9d36e1346b093028fe981ef400ac065c7abbb"
> +
> +pre_configure() {
> +if [ "$CROSS_BUILD" ]; then
> + # disable generating a man page with help2man while cross compiling.
> + sed -i '/^man_MANS = compute.1$/d' Makefile.in
help2man builds man pages from --help output. Switching to the system-wide version won't change this.
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029/files/1c6e4177a21c2842e7a0f093d5f64285122c9e4a#r59827092
> +pkgname="compute"
> +version="1.0.4"
> +revision=4
> +build_style=gnu-configure
> +short_desc="A command-line program that performs simple calculations on input files"
> +maintainer="oliver <ohemming@gmail.com>"
> +license="GPL-3"
> +homepage="http://compute.teamerlich.org/"
> +hostmakedepends="gperf perl"
> +distfiles="https://github.com/agordon/compute/releases/download/v${version}/${pkgname}-${version}.tar.gz"
> +checksum="cd0d09b2d7526fef34eb3f09e5b9d36e1346b093028fe981ef400ac065c7abbb"
> +
> +pre_configure() {
> +if [ "$CROSS_BUILD" ]; then
> + # disable generating a man page with help2man while cross compiling.
> + sed -i '/^man_MANS = compute.1$/d' Makefile.in
Can we make manpages anyway?
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029/files/1c6e4177a21c2842e7a0f093d5f64285122c9e4a#r59832294
> +pkgname="compute"
> +version="1.0.4"
> +revision=4
> +build_style=gnu-configure
> +short_desc="A command-line program that performs simple calculations on input files"
> +maintainer="oliver <ohemming@gmail.com>"
> +license="GPL-3"
> +homepage="http://compute.teamerlich.org/"
> +hostmakedepends="gperf perl"
> +distfiles="https://github.com/agordon/compute/releases/download/v${version}/${pkgname}-${version}.tar.gz"
> +checksum="cd0d09b2d7526fef34eb3f09e5b9d36e1346b093028fe981ef400ac065c7abbb"
> +
> +pre_configure() {
> +if [ "$CROSS_BUILD" ]; then
> + # disable generating a man page with help2man while cross compiling.
> + sed -i '/^man_MANS = compute.1$/d' Makefile.in
The proper way to provide man-pages while cross compiling is building natively for the host and moving them to another directory, take a look at coreutils.
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029/files/1c6e4177a21c2842e7a0f093d5f64285122c9e4a#r59832354
> +pkgname=3D"compute"
> +version=3D"1.0.4"
> +revision=3D4
> +build_style=3Dgnu-configure
> +short_desc=3D"A command-line program that performs simple calculations=
on input files"
> +maintainer=3D"oliver <ohemming@gmail.com>"
> +license=3D"GPL-3"
> +homepage=3D"http://compute.teamerlich.org/"
> +hostmakedepends=3D"gperf perl"
> +distfiles=3D"https://github.com/agordon/compute/releases/download/v${v=
ersion}/${pkgname}-${version}.tar.gz"
> +checksum=3D"cd0d09b2d7526fef34eb3f09e5b9d36e1346b093028fe981ef400ac065=
c7abbb"
> +
> +pre_configure() {
> +if [ "$CROSS_BUILD" ]; then
> + # disable generating a man page with help2man while cross compiling.
> + sed -i '/^man_MANS =3D compute.1$/d' Makefile.in
It looks like the man page is provided as part of the source tar file.
[oliver@fonddulac src-builds]$ tar ztvf
./hostdir/sources/compute-1.0.4/compute-1.0.4.tar.gz compute-1.0.4/comput=
e.1
-rw-r--r-- 0/0 4660 2014-04-11 19:44 compute-1.0.4/compute.1
When I build the package locally on x86_64 and install, I have a file wit=
h
the same name and size
[oliver@fonddulac src-builds]$ xbps-query -f compute | grep 1$
/usr/share/man/man1/compute.1
[oliver@fonddulac src-builds]$ ls -l /usr/share/man/man1/compute.1
-rw-r--r-- 1 root root 4660 Apr 13 20:06 /usr/share/man/man1/compute.1
The only difference is the date in the man page (not sure if that is
important)
The source one is:
.TH COMPUTE "1" "April 2014" "compute (compute) 1.0.4" "User Commands"
The compiled version is:
.TH COMPUTE "1" "April 2016" "compute (compute) 1.0.4" "User Commands"
I modified the template so it now looks like this (outside of the main
part.) Basically, I'm just copying the file over
pre_configure() {
if [ "$CROSS_BUILD" ]; then
# disable generating a man page with help2man while cross=
compiling.
sed -i '/^man_MANS =3D compute.1$/d' Makefile.in
fi
}
do_install() {
make DESTDIR=3D${DESTDIR} install
if [ "$CROSS_BUILD" ]; then
mkdir -p ${DESTDIR}/usr/share/man/man1
mv ${wrksrc}/${pkgname}.1 ${DESTDIR}/usr/share/man/man1/
fi
}
It builds both x86 and armv the same:
[oliver@fonddulac src-builds]$ tar Jtvf ./hostdir/binpkgs/compute*arm*
-rw-r--r-- root/root 971 1969-12-31 19:00 ./props.plist
-rw-r--r-- root/root 2545 1969-12-31 19:00 ./files.plist
-rw-r--r-- 0/0 4660 2016-04-15 14:58
./usr/share/man/man1/compute.1
-rw-r--r-- 0/0 7930 2016-04-15 14:58
./usr/share/compute/examples/readme.md
-rw-r--r-- 0/0 1026495 2016-04-15 14:58
./usr/share/compute/examples/genes.txt
-rw-r--r-- 0/0 1818 2016-04-15 14:58
./usr/share/compute/examples/scores_h.txt
-rw-r--r-- 0/0 1026624 2016-04-15 14:58
./usr/share/compute/examples/genes_h.txt
-rw-r--r-- 0/0 1801 2016-04-15 14:58
./usr/share/compute/examples/scores.txt
-rwxr-xr-x 0/0 47040 2016-04-15 14:58 ./usr/bin/compute
[oliver@fonddulac src-builds]$ tar Jtvf ./hostdir/binpkgs/compute*86*
-rw-r--r-- root/root 931 1969-12-31 19:00 ./props.plist
-rw-r--r-- root/root 2545 1969-12-31 19:00 ./files.plist
-rw-r--r-- 0/0 4660 2016-04-15 14:58
./usr/share/man/man1/compute.1
-rw-r--r-- 0/0 7930 2016-04-15 14:58
./usr/share/compute/examples/readme.md
-rw-r--r-- 0/0 1026495 2016-04-15 14:58
./usr/share/compute/examples/genes.txt
-rw-r--r-- 0/0 1818 2016-04-15 14:58
./usr/share/compute/examples/scores_h.txt
-rw-r--r-- 0/0 1026624 2016-04-15 14:58
./usr/share/compute/examples/genes_h.txt
-rw-r--r-- 0/0 1801 2016-04-15 14:58
./usr/share/compute/examples/scores.txt
-rwxr-xr-x 0/0 51920 2016-04-15 14:58 ./usr/bin/compute
Any thoughts on this method?
On Fri, Apr 15, 2016 at 2:40 AM, Juan RP <notifications@github.com> wrote=
:
> In srcpkgs/compute/template
> <https://github.com/voidlinux/void-packages/pull/4029#discussion_r59832=
354>
> :
>
> > +pkgname=3D"compute"
> > +version=3D"1.0.4"
> > +revision=3D4
> > +build_style=3Dgnu-configure
> > +short_desc=3D"A command-line program that performs simple calculatio=
ns on input files"
> > +maintainer=3D"oliver <ohemming@gmail.com>"
> > +license=3D"GPL-3"
> > +homepage=3D"http://compute.teamerlich.org/"
> > +hostmakedepends=3D"gperf perl"
> > +distfiles=3D"https://github.com/agordon/compute/releases/download/v$=
{version}/${pkgname}-${version}.tar.gz"
> > +checksum=3D"cd0d09b2d7526fef34eb3f09e5b9d36e1346b093028fe981ef400ac0=
65c7abbb"
> > +
> > +pre_configure() {
> > +if [ "$CROSS_BUILD" ]; then
> > + # disable generating a man page with help2man while cross compiling=
.
> > + sed -i '/^man_MANS =3D compute.1$/d' Makefile.in
>
> The proper way to provide man-pages while cross compiling is building
> natively for the host and moving them to another directory, take a look=
at
> coreutils.
>
> =E2=80=94
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
> <https://github.com/voidlinux/void-packages/pull/4029/files/1c6e4177a21=
c2842e7a0f093d5f64285122c9e4a#r59832354>
>
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029/files/1c6e4177a21c28=
42e7a0f093d5f64285122c9e4a#r59930457=
> +pkgname="compute"
> +version="1.0.4"
> +revision=4
> +build_style=gnu-configure
> +short_desc="A command-line program that performs simple calculations on input files"
> +maintainer="oliver <ohemming@gmail.com>"
> +license="GPL-3"
> +homepage="http://compute.teamerlich.org/"
> +hostmakedepends="gperf perl"
> +distfiles="https://github.com/agordon/compute/releases/download/v${version}/${pkgname}-${version}.tar.gz"
> +checksum="cd0d09b2d7526fef34eb3f09e5b9d36e1346b093028fe981ef400ac065c7abbb"
> +
> +pre_configure() {
> +if [ "$CROSS_BUILD" ]; then
> + # disable generating a man page with help2man while cross compiling.
> + sed -i '/^man_MANS = compute.1$/d' Makefile.in
If they already provide a manpage, and help2man is only really used to update the date, then by all means just vman the man page.
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029/files/1c6e4177a21c2842e7a0f093d5f64285122c9e4a#r59930640
> +pkgname=3D"compute"
> +version=3D"1.0.4"
> +revision=3D4
> +build_style=3Dgnu-configure
> +short_desc=3D"A command-line program that performs simple calculations=
on input files"
> +maintainer=3D"oliver <ohemming@gmail.com>"
> +license=3D"GPL-3"
> +homepage=3D"http://compute.teamerlich.org/"
> +hostmakedepends=3D"gperf perl"
> +distfiles=3D"https://github.com/agordon/compute/releases/download/v${v=
ersion}/${pkgname}-${version}.tar.gz"
> +checksum=3D"cd0d09b2d7526fef34eb3f09e5b9d36e1346b093028fe981ef400ac065=
c7abbb"
> +
> +pre_configure() {
> +if [ "$CROSS_BUILD" ]; then
> + # disable generating a man page with help2man while cross compiling.
> + sed -i '/^man_MANS =3D compute.1$/d' Makefile.in
Thanks... any concerns with these two functions?
pre_configure() {
if [ "$CROSS_BUILD" ]; then
# disable updating the man page with help2man while cross=
compiling.
sed -i '/^man_MANS =3D compute.1$/d' Makefile.in
fi
}
do_install() {
make DESTDIR=3D${DESTDIR} install
if [ "$CROSS_BUILD" ]; then
vman ${wrksrc}/${pkgname}.1
fi
}
On Fri, Apr 15, 2016 at 3:45 PM, Toyam Cox <notifications@github.com> wro=
te:
> In srcpkgs/compute/template
> <https://github.com/voidlinux/void-packages/pull/4029#discussion_r59930=
640>
> :
>
> > +pkgname=3D"compute"
> > +version=3D"1.0.4"
> > +revision=3D4
> > +build_style=3Dgnu-configure
> > +short_desc=3D"A command-line program that performs simple calculatio=
ns on input files"
> > +maintainer=3D"oliver <ohemming@gmail.com>"
> > +license=3D"GPL-3"
> > +homepage=3D"http://compute.teamerlich.org/"
> > +hostmakedepends=3D"gperf perl"
> > +distfiles=3D"https://github.com/agordon/compute/releases/download/v$=
{version}/${pkgname}-${version}.tar.gz"
> > +checksum=3D"cd0d09b2d7526fef34eb3f09e5b9d36e1346b093028fe981ef400ac0=
65c7abbb"
> > +
> > +pre_configure() {
> > +if [ "$CROSS_BUILD" ]; then
> > + # disable generating a man page with help2man while cross compiling=
.
> > + sed -i '/^man_MANS =3D compute.1$/d' Makefile.in
>
> If they already provide a manpage, and help2man is only really used to
> update the date, then by all means just vman the man page.
>
> =E2=80=94
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
> <https://github.com/voidlinux/void-packages/pull/4029/files/1c6e4177a21=
c2842e7a0f093d5f64285122c9e4a#r59930640>
>
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029/files/1c6e4177a21c28=
42e7a0f093d5f64285122c9e4a#r59933416=
> +pkgname="compute"
> +version="1.0.4"
> +revision=4
> +build_style=gnu-configure
> +short_desc="A command-line program that performs simple calculations on input files"
> +maintainer="oliver <ohemming@gmail.com>"
> +license="GPL-3"
> +homepage="http://compute.teamerlich.org/"
> +hostmakedepends="gperf perl"
> +distfiles="https://github.com/agordon/compute/releases/download/v${version}/${pkgname}-${version}.tar.gz"
> +checksum="cd0d09b2d7526fef34eb3f09e5b9d36e1346b093028fe981ef400ac065c7abbb"
> +
> +pre_configure() {
> +if [ "$CROSS_BUILD" ]; then
> + # disable generating a man page with help2man while cross compiling.
> + sed -i '/^man_MANS = compute.1$/d' Makefile.in
Yes, please install the manpage in `post_install` instead.
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029/files/1c6e4177a21c2842e7a0f093d5f64285122c9e4a#r59936631
> +pkgname=3D"compute"
> +version=3D"1.0.4"
> +revision=3D4
> +build_style=3Dgnu-configure
> +short_desc=3D"A command-line program that performs simple calculations o=
n input files"
> +maintainer=3D"oliver <ohemming@gmail.com>"
> +license=3D"GPL-3"
> +homepage=3D"http://compute.teamerlich.org/"
> +hostmakedepends=3D"gperf perl"
> +distfiles=3D"https://github.com/agordon/compute/releases/download/v${ver=
sion}/${pkgname}-${version}.tar.gz"
> +checksum=3D"cd0d09b2d7526fef34eb3f09e5b9d36e1346b093028fe981ef400ac065c7=
abbb"
> +
> +pre_configure() {
> +if [ "$CROSS_BUILD" ]; then
> + # disable generating a man page with help2man while cross compiling.
> + sed -i '/^man_MANS =3D compute.1$/d' Makefile.in
Right - lets me get rid of the unneeded make... the functions are now
pre_configure() {
if [ "$CROSS_BUILD" ]; then
# disable updating the man page with help2man while cross
compiling.
sed -i '/^man_MANS =3D compute.1$/d' Makefile.in
fi
}
post_install() {
if [ "$CROSS_BUILD" ]; then
vman ${wrksrc}/${pkgname}.1
fi
}
On Fri, Apr 15, 2016 at 4:32 PM, Toyam Cox <notifications@github.com> wrote:
> In srcpkgs/compute/template
> <https://github.com/voidlinux/void-packages/pull/4029#discussion_r5993663=
1>
> :
>
> > +pkgname=3D"compute"
> > +version=3D"1.0.4"
> > +revision=3D4
> > +build_style=3Dgnu-configure
> > +short_desc=3D"A command-line program that performs simple calculations=
on input files"
> > +maintainer=3D"oliver <ohemming@gmail.com>"
> > +license=3D"GPL-3"
> > +homepage=3D"http://compute.teamerlich.org/"
> > +hostmakedepends=3D"gperf perl"
> > +distfiles=3D"https://github.com/agordon/compute/releases/download/v${v=
ersion}/${pkgname}-${version}.tar.gz"
> > +checksum=3D"cd0d09b2d7526fef34eb3f09e5b9d36e1346b093028fe981ef400ac065=
c7abbb"
> > +
> > +pre_configure() {
> > +if [ "$CROSS_BUILD" ]; then
> > + # disable generating a man page with help2man while cross compiling.
> > + sed -i '/^man_MANS =3D compute.1$/d' Makefile.in
>
> Yes, please install the manpage in post_install instead.
>
> =E2=80=94
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
> <https://github.com/voidlinux/void-packages/pull/4029/files/1c6e4177a21c2=
842e7a0f093d5f64285122c9e4a#r59936631>
>
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029/files/1c6e4177a21c2842=
e7a0f093d5f64285122c9e4a#r59940261=
> +pkgname="compute"
> +version="1.0.4"
> +revision=4
> +build_style=gnu-configure
> +short_desc="A command-line program that performs simple calculations on input files"
> +maintainer="oliver <ohemming@gmail.com>"
> +license="GPL-3"
> +homepage="http://compute.teamerlich.org/"
> +hostmakedepends="gperf perl"
> +distfiles="https://github.com/agordon/compute/releases/download/v${version}/${pkgname}-${version}.tar.gz"
> +checksum="cd0d09b2d7526fef34eb3f09e5b9d36e1346b093028fe981ef400ac065c7abbb"
> +
> +pre_configure() {
> +if [ "$CROSS_BUILD" ]; then
> + # disable generating a man page with help2man while cross compiling.
> + sed -i '/^man_MANS = compute.1$/d' Makefile.in
should be
`vman compute.1` so no extra vars.
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029/files/1c6e4177a21c2842e7a0f093d5f64285122c9e4a#r59951815
> +pkgname=3D"compute"
> +version=3D"1.0.4"
> +revision=3D4
> +build_style=3Dgnu-configure
> +short_desc=3D"A command-line program that performs simple calculations o=
n input files"
> +maintainer=3D"oliver <ohemming@gmail.com>"
> +license=3D"GPL-3"
> +homepage=3D"http://compute.teamerlich.org/"
> +hostmakedepends=3D"gperf perl"
> +distfiles=3D"https://github.com/agordon/compute/releases/download/v${ver=
sion}/${pkgname}-${version}.tar.gz"
> +checksum=3D"cd0d09b2d7526fef34eb3f09e5b9d36e1346b093028fe981ef400ac065c7=
abbb"
> +
> +pre_configure() {
> +if [ "$CROSS_BUILD" ]; then
> + # disable generating a man page with help2man while cross compiling.
> + sed -i '/^man_MANS =3D compute.1$/d' Makefile.in
Thanks... just committed again. I appreciate all the time you're putting
into this for me (and the other members of the team too)
On Fri, Apr 15, 2016 at 6:51 PM, Toyam Cox <notifications@github.com> wrote:
> In srcpkgs/compute/template
> <https://github.com/voidlinux/void-packages/pull/4029#discussion_r5995181=
5>
> :
>
> > +pkgname=3D"compute"
> > +version=3D"1.0.4"
> > +revision=3D4
> > +build_style=3Dgnu-configure
> > +short_desc=3D"A command-line program that performs simple calculations=
on input files"
> > +maintainer=3D"oliver <ohemming@gmail.com>"
> > +license=3D"GPL-3"
> > +homepage=3D"http://compute.teamerlich.org/"
> > +hostmakedepends=3D"gperf perl"
> > +distfiles=3D"https://github.com/agordon/compute/releases/download/v${v=
ersion}/${pkgname}-${version}.tar.gz"
> > +checksum=3D"cd0d09b2d7526fef34eb3f09e5b9d36e1346b093028fe981ef400ac065=
c7abbb"
> > +
> > +pre_configure() {
> > +if [ "$CROSS_BUILD" ]; then
> > + # disable generating a man page with help2man while cross compiling.
> > + sed -i '/^man_MANS =3D compute.1$/d' Makefile.in
>
> should be
> vman compute.1 so no extra vars.
>
> =E2=80=94
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
> <https://github.com/voidlinux/void-packages/pull/4029/files/1c6e4177a21c2=
842e7a0f093d5f64285122c9e4a#r59951815>
>
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029/files/1c6e4177a21c2842=
e7a0f093d5f64285122c9e4a#r59954143=
It's git best practice to put any comments you put in your commit message after a blank line, so
```
New package: compute-1.0.4
<comments>
```
Also, instead of both functions, adding the following patch to `srcpkgs/compute/patches/no_help2man_regeneration.patch` works great
```
--- Makefile.in 2016-04-15 19:56:08.257716796 -0400
+++ Makefile.in 2016-04-15 19:56:03.663451813 -0400
@@ -3088,12 +3088,6 @@
uninstall-local uninstall-man uninstall-man1
-compute.1: compute
- PATH='$(abs_top_builddir)$(PATH_SEPARATOR)'$$PATH \
- $(abs_top_srcdir)/man/help2man --include=$(top_srcdir)/man/compute.x compute -o $@-t
- chmod u=rw,go=r $@-t
- mv -f $@-t $@
-
# Verify that all source files using _() are listed in po/POTFILES.in.
# The idea is to run this before making pretests, as well as official
# releases, so that translators will be sure to have all the messages.
```
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029#issuecomment-210691705
Thanks! Can't say I understand how the patch is doing things but it seem=
s
a little more graceful than functions.
On Fri, Apr 15, 2016 at 8:01 PM, Toyam Cox <notifications@github.com> wro=
te:
> It's git best practice to put any comments you put in your commit messa=
ge
> after a blank line, so
>
> New package: compute-1.0.4
>
> <comments>
>
> Also, instead of both functions, adding the following patch to
> srcpkgs/compute/patches/no_help2man_regeneration.patch works great
>
> --- Makefile.in 2016-04-15 19:56:08.257716796 -0400
> +++ Makefile.in 2016-04-15 19:56:03.663451813 -0400
> @@ -3088,12 +3088,6 @@
> uninstall-local uninstall-man uninstall-man1
>
>
> -compute.1: compute
> - PATH=3D'$(abs_top_builddir)$(PATH_SEPARATOR)'$$PATH \
> - $(abs_top_srcdir)/man/help2man --include=3D$(top_srcdir)/man/com=
pute.x compute -o $@-t
> - chmod u=3Drw,go=3Dr $@-t
> - mv -f $@-t $@
> -
> # Verify that all source files using _() are listed in po/POTFILES.in.=
> # The idea is to run this before making pretests, as well as official
> # releases, so that translators will be sure to have all the messages.=
>
> =E2=80=94
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
> <https://github.com/voidlinux/void-packages/pull/4029#issuecomment-2106=
91705>
>
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029#issuecomment-2109266=
06=
It allows the file `compute.1` to satisfy the requirement for `compute.1` to be present, rather than using the requirement within the makefile.
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029#issuecomment-210953273
> @@ -0,0 +1,12 @@
> +# Template file for 'compute'
> +pkgname="compute"
> +version="1.0.4"
> +revision=8
Revision 1 until it has been committed to the repository.
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029/files/11e9b13174646aca571df15f9b054995cae8959c#r59978092
Merged #4029.
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4029#event-630454155