@WilliamO7 pushed 1 commit.
f743a9b plymouth: update to 0.8.8.
---
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/voidlinux/void-packages/pull/4440/files/ffdc918c89e1f1cc5c8ffd0bdc3a17e4f3ef0117..f743a9b699b89a4a36429d04547463e8c5a81a80
Just found out I messed up with the commits on my end...
Trying to squash the two into one now...
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4440#issuecomment-230800257
All previous edits should be done now.
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4440#issuecomment-230803687
Hmm, only i686 and x86_64 glib packages build correctly... Looking into it...
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4440#issuecomment-230862739
The culprit seems to be [`rpmatch(3)`](http://linux.die.net/man/3/rpmatch) which musl libc does not have.
A simple, non locale aware replacement could be written to accept e.g. "yes", "y", "no", "n" as valid strings returning 0 for negative and 1 for affirmative strings, or -1 otherwise.
This could be patched into `main.c` itself enclosed in `#if !defined(__GLIBC__)` like this:
```C
#if !defined(__GLIBC__)
int rpmatch(const char* response)
{
if (!strcasecmp(response, "n") ||
!strcasecmp(response, "no"))
return 0;
if (!strcasecmp(response, "y") ||
!strcasecmp(response, "yes"))
return 1;
return -1;
}
#endif /* !defined(__GLIBC__) */
```
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4440#issuecomment-230867117
So should we not build this for musl then?
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4440#issuecomment-230873830
@WilliamO7 I think @Duncaen and @pullmoll are discussing the ideal workaround so we can build it for musl.
---
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4440#issuecomment-230890518
@Duncaen I tend to agree, while musl has `setlocale()` and we could use `gettext-devel`...
Then `gettext()` could used to query the localized strings for e.g. `"yes", "no", "^[yY]" and "^[nN]"` compare their translation to the response.
Just a thought. For now the hack should suffice.
---
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4440#issuecomment-230892079
@pullmoll Would it be correct to now `makedepends` on `musl-rpmatch-devel` for this package?
---
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4440#issuecomment-231084037
Yes, I think `musl-rpmatch-devel` could now be used.
Instead of trying to patch `configure`, or even `configure.ac` and/or `Makefile.am` in case you wanted to add `automake` and `libtool` to hostdepends, it should be sufficient to have a global scope `LIBS=-lrpmatch` or perhaps `LDFLAGS=-lrpmatch`.
---
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4440#issuecomment-231087347
Sigh, still doesn't build on musl (and yes, I did move the include up and build again)...
I would look for another file that includes rpmatch, but I really do not have the time right now.
---
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4440#issuecomment-231152846
I'll probably take a look later this afternoon.
---
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4440#issuecomment-231163318
Closed #4440 via 96cd364ee1f3165774a7278557438fbf778cda0a.
---
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4440#event-716437007
@WilliamO7 LMK if the package works for you. I didn't take the time to test the results.
---
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/voidlinux/void-packages/pull/4440#issuecomment-231387320