Re: [voidlinux/void-packages] Astroid (#4751)
Instead of forking and messing up versioning (version=99) you could just add a patch.
the describtion was changes,
the commits where squashed,
a patch was used to depend on an upstream version.
Gottox requested changes on this pull request.
> +pkgname="astroid"
+version="0.6"
+revision="1"
+build_style="scons"
+short_desc="Graphical lightweight and fast email client for notmuch"
+maintainer="M. Dietrich <mdt@pyneo.org>"
+license="GPL-3"
+homepage="https://github.com/astroidmail/astroid"
+distfiles="https://github.com/astroidmail/astroid/archive/v${version}.tar.gz"
+checksum="b91e846bb009b7770a5161ce323c6ac729592ce12e3ed697f9b435b587dd31b4"
+depends="libnotmuch webkitgtk boost libsass libpeas notmuch gtkmm"
+makedepends="gcc-c++ git pkg-config scons gobject-introspection boost-devel gmime-devel gtkmm-devel libnotmuch-devel libpeas-devel libsass-devel webkitgtk-devel"
+
+do_configure() {
+ true
+}
remove this noop function.
> +distfiles="https://github.com/astroidmail/astroid/archive/v${version}.tar.gz"
+checksum="b91e846bb009b7770a5161ce323c6ac729592ce12e3ed697f9b435b587dd31b4"
+depends="libnotmuch webkitgtk boost libsass libpeas notmuch gtkmm"
+makedepends="gcc-c++ git pkg-config scons gobject-introspection boost-devel gmime-devel gtkmm-devel libnotmuch-devel libpeas-devel libsass-devel webkitgtk-devel"
+
+do_configure() {
+ true
+}
+
+do_build() {
+ scons --release=${version} --install-sandbox=${DESTDIR} --prefix=/usr
+}
+
+do_install() {
+ scons --release=${version} --install-sandbox=${DESTDIR} --prefix=/usr install
+}
Can't find any patch in this commit.
> @@ -0,0 +1,25 @@
+# Template file for 'astroid'
+pkgname="astroid"
+version="0.6"
+revision="1"
+build_style="scons"
+short_desc="Graphical lightweight and fast email client for notmuch"
+maintainer="M. Dietrich <mdt@pyneo.org>"
+license="GPL-3"
+homepage="https://github.com/astroidmail/astroid"
+distfiles="https://github.com/astroidmail/astroid/archive/v${version}.tar.gz"
+checksum="b91e846bb009b7770a5161ce323c6ac729592ce12e3ed697f9b435b587dd31b4"
+depends="libnotmuch webkitgtk boost libsass libpeas notmuch gtkmm"
+makedepends="gcc-c++ git pkg-config scons gobject-introspection boost-devel gmime-devel gtkmm-devel libnotmuch-devel libpeas-devel libsass-devel webkitgtk-devel"
* gcc-c++ can be remove
* Is git needed to build?
* gobject-introspection, pkg-config, and scons need to go to hostmakedepends
> @@ -0,0 +1,25 @@
+# Template file for 'astroid'
+pkgname="astroid"
+version="0.6"
+revision="1"
+build_style="scons"
+short_desc="Graphical lightweight and fast email client for notmuch"
+maintainer="M. Dietrich <mdt@pyneo.org>"
+license="GPL-3"
+homepage="https://github.com/astroidmail/astroid"
+distfiles="https://github.com/astroidmail/astroid/archive/v${version}.tar.gz"
+checksum="b91e846bb009b7770a5161ce323c6ac729592ce12e3ed697f9b435b587dd31b4"
+depends="libnotmuch webkitgtk boost libsass libpeas notmuch gtkmm"
Sorry for the long delay. :)
depends are automaticly detected. This can be removed.
@emdete Is this PR still active?
3 months. @emdete shall this remain open or be closed?