I accidentally deleted my previous commit, so I recreated a new.
@Duncaen all changes are done, except for done_build(), because without him the sofware is build in the `build3.4` folder instead of `build`. Which cause an error during do_install step.
You can view, comment on, or merge this pull request online at:
https://github.com/voidlinux/void-packages/pull/4838
-- Commit Summary --
* New package: lightdm-gtk-greeter-settings-1.2.1
-- File Changes --
A srcpkgs/lightdm-gtk-greeter-settings/template (20)
-- Patch Links --
https://github.com/voidlinux/void-packages/pull/4838.patch
https://github.com/voidlinux/void-packages/pull/4838.diff
Alventoor commented on this pull request.
> +build_style=python-module
+python_versions="3.4"
+pycompile_version="3.4"
+pycompile_module="lightdm_gtk_greeter_settings"
+hostmakedepends="python3.4-distutils-extra intltool"
+depends="lightdm-gtk3-greeter python3.4-gobject"
+short_desc="Settings editor for LightDM GTK+ Greeter"
+maintainer="Julien Marconnet <julienm99@gmail.com>"
+license="GPL-3"
+homepage="https://launchpad.net/lightdm-gtk-greeter-settings"
+distfiles="https://launchpad.net/${pkgname}/${version%.*}/${version}/+download/${pkgname}-${version}.tar.gz"
+checksum=ab91027b56ca0e0c98a38169acc453c08801bc4937dc1a53bd6e98b7aaceea96
+
+do_build() {
+ python3 setup.py build
+}
When I remove do_build(), I get the following error message :` ERROR: lightdm-gtk-greeter-settings-1.2.1_1: failed to run do_install() at line 49.`.
This was because without do_build the software is build in the `build3.4` folder. Or, during do_install step lightdm-gtk-greeter-settings creates the `build3.4` folder, what appears to conflict.
I searched, but I couldn't find a solution for removing do_build.
Gottox commented on this pull request.
> +build_style=python-module
+python_versions="3.4"
+pycompile_version="3.4"
+pycompile_module="lightdm_gtk_greeter_settings"
+hostmakedepends="python3.4-distutils-extra intltool"
+depends="lightdm-gtk3-greeter python3.4-gobject"
+short_desc="Settings editor for LightDM GTK+ Greeter"
+maintainer="Julien Marconnet <julienm99@gmail.com>"
+license="GPL-3"
+homepage="https://launchpad.net/lightdm-gtk-greeter-settings"
+distfiles="https://launchpad.net/${pkgname}/${version%.*}/${version}/+download/${pkgname}-${version}.tar.gz"
+checksum=ab91027b56ca0e0c98a38169acc453c08801bc4937dc1a53bd6e98b7aaceea96
+
+do_build() {
+ python3 setup.py build
+}
That means the buildsystem is somewhat broken. Unfortunately using do_build directly breaks various features of xpbs. @asergi Do you have an idea how to fix this?
asergi commented on this pull request.
> +build_style=python-module
+python_versions="3.4"
+pycompile_version="3.4"
+pycompile_module="lightdm_gtk_greeter_settings"
+hostmakedepends="python3.4-distutils-extra intltool"
+depends="lightdm-gtk3-greeter python3.4-gobject"
+short_desc="Settings editor for LightDM GTK+ Greeter"
+maintainer="Julien Marconnet <julienm99@gmail.com>"
+license="GPL-3"
+homepage="https://launchpad.net/lightdm-gtk-greeter-settings"
+distfiles="https://launchpad.net/${pkgname}/${version%.*}/${version}/+download/${pkgname}-${version}.tar.gz"
+checksum=ab91027b56ca0e0c98a38169acc453c08801bc4937dc1a53bd6e98b7aaceea96
+
+do_build() {
+ python3 setup.py build
+}
The only thing I can think of without too much hassle is to just skip the build phase:
```
do_build() {
:
}
```
asergi requested changes on this pull request.
> @@ -0,0 +1,20 @@
+# Template file for 'lightdm-gtk-greeter-settings'
+pkgname=lightdm-gtk-greeter-settings
+version=1.2.1
+revision=1
+build_style=python-module
`build_style=python3-module`
> @@ -0,0 +1,20 @@
+# Template file for 'lightdm-gtk-greeter-settings'
+pkgname=lightdm-gtk-greeter-settings
+version=1.2.1
+revision=1
+build_style=python-module
+python_versions="3.4"
+pycompile_version="3.4"
You can remove both `python_versions` and `pycompile_version`. They are no longer needed.
> @@ -0,0 +1,20 @@
+# Template file for 'lightdm-gtk-greeter-settings'
+pkgname=lightdm-gtk-greeter-settings
+version=1.2.1
+revision=1
+build_style=python-module
+python_versions="3.4"
+pycompile_version="3.4"
+pycompile_module="lightdm_gtk_greeter_settings"
+hostmakedepends="python3.4-distutils-extra intltool"
+depends="lightdm-gtk3-greeter python3.4-gobject"
We switched to `python3-*` packages in the meantime, so: `'s/python3\.4/python3/g'`.
asergi commented on this pull request.
> +build_style=python-module
+python_versions="3.4"
+pycompile_version="3.4"
+pycompile_module="lightdm_gtk_greeter_settings"
+hostmakedepends="python3.4-distutils-extra intltool"
+depends="lightdm-gtk3-greeter python3.4-gobject"
+short_desc="Settings editor for LightDM GTK+ Greeter"
+maintainer="Julien Marconnet <julienm99@gmail.com>"
+license="GPL-3"
+homepage="https://launchpad.net/lightdm-gtk-greeter-settings"
+distfiles="https://launchpad.net/${pkgname}/${version%.*}/${version}/+download/${pkgname}-${version}.tar.gz"
+checksum=ab91027b56ca0e0c98a38169acc453c08801bc4937dc1a53bd6e98b7aaceea96
+
+do_build() {
+ python3 setup.py build
+}
This `setup.py` is weird because it creates files at build time in a directory outside the classical `build-X.Y`.
I wouldn't lose too much time at it. Skipping the `do_build()` is fine, imo.