Re: [voidlinux/void-packages] New package: budgie-desktop-10.2.7 (#4875)

Michael Gehring at Thu, 06 Oct 2016 11:30:10 -0700
Remove the .xbps files and squash everything to 1 commit. Please try to use the release tarballs, they contain the only submodule (gvc). It's prefered to not use variables in `homepage`
Jürgen Buchmüller at Thu, 06 Oct 2016 13:33:51 -0700
There is a release v10.2.7 at https://github.com/solus-project/budgie-desktop/archive/v10.2.7.tar.gz so there's really no need to git clone, or is there?
mar1n3r0 at Sat, 08 Oct 2016 01:37:29 -0700
@mar1n3r0 pushed 2 commits. 627f87d New package: budgie-desktop-10.2.7 24e449b Merge branch 'budgie-desktop' of https://github.com/mar1n3r0/void-packages into budgie-desktop
mar1n3r0 at Sat, 08 Oct 2016 01:45:05 -0700
Under no circumstance should you use GitHub generated tarballs to integrate Budgie Desktop into your project/distro/whatever-it-is. These tarballs are not correct, and are not supported by the maintainer. If we determine your package uses GitHub generated tarballs, or bypasses our own release and build processes, your bug will be invalidated and no support will be received. Note that a valid generated tarball for use from git can be generated and hosted in your own infrastructure as follows: ./autogen.sh make distcheck @ebfe What do you mean by remove .xbps files ? Also I tried squashing my last commits but they doubled. I used this command: git reset --soft HEAD~4 && git commit
Michael Gehring at Sat, 08 Oct 2016 01:47:39 -0700
There are non automatically generated release tarballs at https://github.com/solus-project/budgie-desktop/releases/download/v10.2.7/budgie-desktop-10.2.7.tar.xz.
Michael Gehring at Sat, 08 Oct 2016 01:48:59 -0700
> @ebfe What do you mean by remove .xbps files ? the first commit (947e3c3) adds .xbps files in hostdir/binpkgs
mar1n3r0 at Sat, 08 Oct 2016 01:50:16 -0700
Please see previous discussion on this: https://github.com/voidlinux/void-packages/pull/4398 This template makes use of the tarballs which are specifically disa-vowed of by the project authors. This should be refactored to do a git checkout so that you can ensure you actually have all of the tarball since github does not fold in the submodules. There should be no issues with Void policy on this matter since it is still a tagged, repeatable release that is made by the upstream project, only the transport mechanism is changing.
Michael Gehring at Sat, 08 Oct 2016 01:52:35 -0700
There is a difference between autogenerated github tarballs and release tarballs that are uploaded by the maintainers...
mar1n3r0 at Sat, 08 Oct 2016 01:54:06 -0700
So is this final or just a contradiction between reviewers ? Maybe discuss with @the-maldridge and then I can refactor as per agreed decision ?
mar1n3r0 at Sat, 08 Oct 2016 01:57:55 -0700
@mar1n3r0 pushed 2 commits. fcaef25 Merge branch 'budgie-desktop' of https://github.com/mar1n3r0/void-packages into budgie-desktop 185ebb9 Merge branch 'budgie-desktop' of https://github.com/mar1n3r0/void-packages into budgie-desktop
Michael Gehring at Sat, 08 Oct 2016 01:58:16 -0700
I don't know which tarballs you used in the initial PR and the commit is gone so i can't check. Maybe you used the autogenerated one and the real release tarball was overlooked.
Michael Gehring at Sat, 08 Oct 2016 02:16:21 -0700
git rebase -i origin/master assuming origin is the remote you use for https://github.com/voidlinux/void-packages drop the commits that add .xbps files, squash the rest.
mar1n3r0 at Sat, 08 Oct 2016 03:24:58 -0700
[DEBUG] Added `libtls10-2.3.6_1' into the dependency list (/host/binpkgs) libcrypto37-2.3.6_1 (update) breaks installed pkg `libressl-2.3.8_1' libssl38-2.3.6_1 (update) breaks installed pkg `libressl-2.3.8_1' Transaction aborted due to unresolved dependencies. I guess the bot is currently building some packages.
Michael Gehring at Sat, 08 Oct 2016 03:42:05 -0700
> I guess the bot is currently building some packages. No, you probably need to run `./xbps-src update-bootstrap` to update your masterdir
mar1n3r0 at Sat, 08 Oct 2016 03:55:54 -0700
Hmm I ran it and it updated but it seems like the required ones are behind the installed ones, now that I think of it.
mar1n3r0 at Sat, 08 Oct 2016 07:06:58 -0700
This is solved now thanks to @Duncaen. Basically I had to pull latest changes in masterdir first. Here is what happens next: ERROR: [trans] failed to download wget-1.18_1' package fromhttps://repo.voidlinux.eu/current/aarch64': Not Found [DEBUG] [trans] failed to download binpkgs: Device or resource busy
Michael Aldridge at Sat, 08 Oct 2016 08:53:03 -0700
As long as the build is repeatable and is compliant with policy I don't care how the files are retrieved.
mar1n3r0 at Sun, 09 Oct 2016 06:35:50 -0700
@mar1n3r0 pushed 2 commits. 026b885 New package: bugdie-desktop-10.2.7 91efcc7 New package: budgie-desktop-10.2.7
mar1n3r0 at Sun, 09 Oct 2016 06:48:48 -0700
@mar1n3r0 pushed 2 commits. 891776d New package: budgie-desktop-10.2.7 b2d8232 New package: budgie-desktop-10.2.7
Michael Gehring at Sun, 09 Oct 2016 06:49:27 -0700
ebfe requested changes on this pull request. Please squash to one commit. > +version=10.2.7 +revision=1 +build_style=gnu-configure +hostmakedepends="wget automake gtk-doc pkg-config intltool libtool gobject-introspection" +makedepends="libglib-devel gtk+3-devel +libpeas-devel pulseaudio-devel gnome-desktop-devel +mutter-devel gnome-menus-devel libwnck-devel +libupower-glib1 vala libuuid-devel polkit-devel +gettext-devel" +depends="gnome-session" +short_desc="Budgie desktop" +maintainer="Frankie Wilde <train_me_well@abv.bg>" +license="GPL-2, LGPL-2.1" +homepage="https://github.com/solus-project/budgie-desktop" +do_fetch() { + wget --no-check-certificate https://github.com/solus-project/budgie-desktop/releases/download/v${version}/${package}-${version}.tar.xz no need to do this manually, just add it to distfiles. > +libpeas-devel pulseaudio-devel gnome-desktop-devel +mutter-devel gnome-menus-devel libwnck-devel +libupower-glib1 vala libuuid-devel polkit-devel +gettext-devel" +depends="gnome-session" +short_desc="Budgie desktop" +maintainer="Frankie Wilde <train_me_well@abv.bg>" +license="GPL-2, LGPL-2.1" +homepage="https://github.com/solus-project/budgie-desktop" +do_fetch() { + wget --no-check-certificate https://github.com/solus-project/budgie-desktop/releases/download/v${version}/${package}-${version}.tar.xz + cd "${wrksrc}" + tar -xjvf "${pkgname}-${version}.tar.xz" +} +pre_configure() { + ./autogen.sh probably can be dropped. the release tarball already contains a configure script.
mar1n3r0 at Sun, 09 Oct 2016 07:02:24 -0700
If I only knew how to do squashing properly. In this pull request I have 12 commits but when I choose git rebase -i HEAD~12 I see all commits on the upstream repository rather than only mine. After various attempts I am now brought to cherry-picking...
Michael Gehring at Sun, 09 Oct 2016 07:06:25 -0700
``` git fetch origin git rebase -i origin/master ``` assuming origin is the remote you use for https://github.com/voidlinux/void-packages drop the commits that add .xbps files, squash the rest.
Jürgen Buchmüller at Sun, 09 Oct 2016 07:06:46 -0700
FWIW here is a [template that works](http://sprunge.us/HHhb) and should be correct. I could just push it and make it close this PR?
mar1n3r0 at Sun, 09 Oct 2016 07:08:56 -0700
Yes, please do. I feel a bit lost after diverting from my basic workflow with git.
Jürgen Buchmüller at Sun, 09 Oct 2016 07:10:10 -0700
Closed #4875 via 27e2bdf5c00cc8777c921e9fd142fc42714b8d46.
Michael Gehring at Sun, 09 Oct 2016 07:11:06 -0700
@mar1n3r0 HEAD~12 is probably not working like you think it does. Take a look at `man gitrevisions`. @pullmoll Thanks :)
mar1n3r0 at Sun, 09 Oct 2016 07:17:29 -0700
Even git rebase -i origin/master doesn't work as I think. When I execute it basically I see hundreds of commits which are not mine.
mar1n3r0 at Sun, 09 Oct 2016 07:18:17 -0700
Thanks guys for your help and patience, this is my first package and still learning git.
Jürgen Buchmüller at Sun, 09 Oct 2016 07:23:17 -0700
FWIW here's my scheme to prepare and handle a git PR. Do this once in your fork. ``` git remote add upstream git://github.com/voidlinux/void-packages.git ``` Now for a new package ``` git pull --rebase upstream master git checkout -b mystuff { work on it and add files } git add srcpkgs/mystuff git commit git push { more changes } git add srcpkgs/mystuff git commit --amend git push -f { rebase to upstream master again, if there were changes like common/shlibs } git pull --rebase upstream master git push -f ```
mar1n3r0 at Sun, 09 Oct 2016 07:50:45 -0700
Thanks that goes straight to my how-to articles. I was doing the fetch upstream rather than pull, maybe this is why it was outdated.
Toyam Cox at Tue, 11 Oct 2016 07:55:54 -0700
Fetch downloads the upstream, but doesn't combine it with any branch. You need to manually merge or rebase for that to happen. Pull simply does a fetch and a merge all in one.