Re: [voidlinux/void-packages] chromium: update to 54.0.2840.100.
(#5182)
ebfe commented on this pull request.
> @@ -1,14 +1,3 @@
---- ./third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_userspace.c.orig
-+++ ./third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_userspace.c
-@@ -72,7 +72,7 @@
- pthread_setname_np(name);
- #endif
- #if defined(__Userspace_os_Linux)
-- pthread_setname_np(pthread_self(), name);
-+ //pthread_setname_np(pthread_self(), name);
I think this is available on musl with -D_GNU_SOURCE.
ebfe commented on this pull request.
> @@ -1,14 +1,3 @@
---- ./third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_userspace.c.orig
-+++ ./third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_userspace.c
-@@ -72,7 +72,7 @@
- pthread_setname_np(name);
- #endif
- #if defined(__Userspace_os_Linux)
-- pthread_setname_np(pthread_self(), name);
-+ //pthread_setname_np(pthread_self(), name);
Euh, too early...
Just cosmetics, but I think `conf+='foo="bar"'` is nicer than quoting `\"`.
Drop `# XXX: trigger rebuild`.
Also, I feel like the gn configuring and pre-ninja part should be in `do_configure`.