Re: [voidlinux/void-packages] qemu: add smartcard support (#5973)

Michael Gehring at Sun, 12 Mar 2017 12:16:21 -0700
ebfe requested changes on this pull request. Adding libcacard should be a separate commit.
Sir-Boops at Sun, 12 Mar 2017 12:31:26 -0700
Sir-Boops commented on this pull request. > @@ -19,7 +19,7 @@ makedepends="libpng-devel libjpeg-turbo-devel pixman-devel snappy-devel libbluetooth-devel libssh2-devel libusb-devel pulseaudio-devel libnfs-devel $(vopt_if sdl SDL-devel) $(vopt_if sdl2 SDL2-devel) $(vopt_if gtk gtk+-devel) $(vopt_if spice spice-devel) $(vopt_if virgl virglrenderer-devel) - $(vopt_if opengl 'libepoxy-devel libdrm-devel MesaLib-devel')" + $(vopt_if opengl 'libepoxy-devel libdrm-devel MesaLib-devel') libcacard-devel" No, we really don't need it as a default option, i only added it as one as i wasn't aware some don't want it. I'll remove it from the default build options.
Sir-Boops at Sun, 12 Mar 2017 13:10:08 -0700
Put adding libcacard into it's own commit
Enno Boland at Sun, 12 Mar 2017 15:41:50 -0700
Gottox approved this pull request.
Jürgen Buchmüller at Sun, 12 Mar 2017 15:50:19 -0700
For consistency please use `New package: libcacard-2.5.2` as the first commit message.
Michael Gehring at Mon, 13 Mar 2017 01:04:47 -0700
ebfe commented on this pull request. > @@ -0,0 +1,24 @@ +# Template file for 'libcacard' +pkgname=libcacard +version=2.5.2 +revision=1 +build_style=gnu-configure +hostmakedepends="pkg-config" +makedepends="nss-devel glib-devel pcsclite-devel" +short_desc="A library to privide emulation of smart cards to a virtual card reader" typo
Michael Gehring at Mon, 13 Mar 2017 01:05:11 -0700
ebfe approved this pull request.
Toyam Cox at Wed, 15 Mar 2017 11:29:09 -0700
Merged #5973.