Re: [voidlinux/void-packages] xbps-src: preserve proxy environment variables (#8117)

Maurizio Porrato at Fri, 13 Oct 2017 18:35:17 +0000 (UTC)
No special reason. IMO, this implementation is easier to extend in case there's a need to add more variables to the list.
Toyam Cox at Mon, 16 Oct 2017 08:47:39 +0000 (UTC)
Please at least use `$()` instead of `` to denote a subshell.
Michael Gehring at Mon, 16 Oct 2017 02:16:14 -0700
I'm not sure if passing through environment variables into the chroot is a good idea at all. Explicit configuration via an XBPS_PROXYS variable or similar in /etc/conf keeps the chroot independent.
Juan RP at Mon, 16 Oct 2017 03:07:14 -0700
Exactly 2017-10-16 11:16 GMT+02:00 Michael Gehring <notifications@github.com>: > I'm not sure if passing through environment variables into the chroot i= s a > good idea at all. Explicit configuration via an XBPS_PROXYS variable or= > similar in /etc/conf keeps the chroot independent. > > =E2=80=94 > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/voidlinux/void-packages/pull/8117#issuecomment-3368= 28479>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AA0fqYGo6sc_XElgyrLC= Jxx1xKcacoTKks5ssx7dgaJpZM4P4vCV> > . > -- = You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/voidlinux/void-packages/pull/8117#issuecomment-3368414= 89=
pulux at Tue, 17 Oct 2017 07:59:56 +0000 (UTC)
I'm work behind a proxy, set XBPS_PROXYS in /etc/conf dosn't work. This PR works well.
Michael Gehring at Tue, 17 Oct 2017 08:32:24 +0000 (UTC)
> I'm work behind a proxy, set XBPS_PROXYS in /etc/conf dosn't work. > This PR works well. I neither claimed that this PR doesn't work nor that setting XBPS_PROXYS currently works. I just don't think that unconditionally passing through environment variables is a good idea.
Maurizio Porrato at Tue, 17 Oct 2017 02:26:52 -0700
What about using a sudo-like approach where you can define the list of the variables you want to passthrough in a conf file? (`env_keep` in `/etc/sudoers`)
maxice8 at Thu, 03 May 2018 09:10:29 -0700
any updates on this ?