Re: [voidlinux/xbps] xbps-remove: fix --dry-run for --clean-cache (#192)

Jan Tatje at Fri, 02 Sep 2016 14:28:57 -0700

I can change it to pass whatever you want, somehow just read the variable name "arg" and thought of a string. (Even though it's void*!) Should I rather pass a bool* or an int* and use the first bit as flag? I can change it to whatever you think it's best.

Jan Tatje at Tue, 06 Sep 2016 15:28:30 -0700

I changed it to pass a bool pointer.

Juan RP at Tue, 06 Sep 2016 22:47:59 -0700

> bool *done _unused) > { > xbps_dictionary_t repo_pkgd; > const char *binpkg, *rsha256; > char *binpkgsig, *pkgver, *arch; > + bool drun; `bool drun = false;`

Juan RP at Tue, 06 Sep 2016 22:48:22 -0700

> bool *done _unused) > { > xbps_dictionary_t repo_pkgd; > const char *binpkg, *rsha256; > char *binpkgsig, *pkgver, *arch; > + bool drun; > + > + /* Extract drun (dry-run) flag from arg*/ > + if (arg != NULL) > + drun = *(bool*)arg; > + else WIth the var initialized previously you can skip the `else` conditional.

Jan Tatje at Wed, 07 Sep 2016 12:58:29 -0700

Done. Please re-review.

Enno Boland at Wed, 07 Sep 2016 13:02:36 -0700

:+1:

Enno Boland at Wed, 07 Sep 2016 13:03:29 -0700

Merged #192.

avoidr at Sun, 22 Oct 2017 10:04:08 +0000 (UTC)

Hello. I just came across this bug myself. When is the next release/revision of xbps going to be?